Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6513] fix(proxy): enhance ProxyContext #6522

Merged
merged 4 commits into from Apr 13, 2023

Conversation

lyx2000
Copy link
Contributor

@lyx2000 lyx2000 commented Apr 1, 2023

fix #6513

Brief changelog

add the relevant client information into the channel attr when client heartbeat to ProxyContext

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql_analysis.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@lyx2000 lyx2000 requested review from xdkxlk and drpmma April 6, 2023 12:11
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xdkxlk
xdkxlk previously approved these changes Apr 7, 2023
@lyx2000 lyx2000 requested a review from drpmma April 9, 2023 17:08
drpmma
drpmma previously approved these changes Apr 10, 2023
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouxinyu
Copy link
Member

Please rebase the develop branch to resolve the CI issue, please refer to #6560 for more details.

Signed-off-by: lyx <1419360299@qq.com>
Signed-off-by: lyx2000 <1419360299@qq.com>
Signed-off-by: lyx <1419360299@qq.com>
Signed-off-by: lyx <1419360299@qq.com>
@lyx2000 lyx2000 dismissed stale reviews from drpmma and xdkxlk via cc30b96 April 13, 2023 09:43
@lyx2000 lyx2000 force-pushed the feature/improve-proxyContext branch from cc30b96 to a551ebc Compare April 13, 2023 09:59
@codecov-commenter
Copy link

Codecov Report

Merging #6522 (cc30b96) into develop (d9a7315) will increase coverage by 0.01%.
The diff coverage is 52.11%.

❗ Current head cc30b96 differs from pull request most recent head a551ebc. Consider uploading reports for the commit a551ebc to get more accurate results

@@              Coverage Diff              @@
##             develop    #6522      +/-   ##
=============================================
+ Coverage      43.07%   43.09%   +0.01%     
- Complexity      8992     8998       +6     
=============================================
  Files           1107     1107              
  Lines          78260    78295      +35     
  Branches       10201    10202       +1     
=============================================
+ Hits           33713    33743      +30     
- Misses         40318    40329      +11     
+ Partials        4229     4223       -6     
Impacted Files Coverage Δ
...ker/processor/DefaultPullMessageResultHandler.java 38.46% <0.00%> (ø)
...ocketmq/broker/processor/PeekMessageProcessor.java 3.22% <0.00%> (ø)
...rocketmq/broker/processor/PopMessageProcessor.java 37.61% <0.00%> (ø)
...cketmq/broker/processor/QueryMessageProcessor.java 4.65% <0.00%> (ø)
.../apache/rocketmq/proxy/common/ContextVariable.java 0.00% <ø> (ø)
...xy/grpc/interceptor/AuthenticationInterceptor.java 0.00% <0.00%> (ø)
...proxy/remoting/activity/ClientManagerActivity.java 0.00% <0.00%> (ø)
...etmq/remoting/metrics/RemotingMetricsConstant.java 0.00% <ø> (-70.59%) ⬇️
...ketmq/remoting/metrics/RemotingMetricsManager.java 10.81% <ø> (-4.58%) ⬇️
...apache/rocketmq/remoting/protocol/RequestCode.java 0.00% <ø> (ø)
... and 7 more

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhouxinyu zhouxinyu merged commit d34a28b into apache:develop Apr 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the proxy context in the remoting protocol server
5 participants