[ISSUE #6572] MQAdmin support getKvConfig command

[ferrirW]

What is the purpose of the change

fix #6572

Brief changelog

add getKvConfig command in MQAdminStartup

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

• Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[codecov-commenter]

Codecov Report

Merging #6573 (054ae8c) into develop (f44a1c3) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6573      +/-   ##
=============================================
+ Coverage      43.08%   43.12%   +0.04%     
+ Complexity      8994     8992       -2     
=============================================
  Files           1107     1108       +1     
  Lines          78257    78279      +22     
  Branches       10201    10201              
=============================================
+ Hits           33716    33758      +42     
+ Misses         40318    40293      -25     
- Partials        4223     4228       +5     

Impacted Files	Coverage Δ
.../apache/rocketmq/tools/command/MQAdminStartup.java	0.00% <0.00%> (ø)
...etmq/tools/command/namesrv/GetKvConfigCommand.java	0.00% <0.00%> (ø)
...q/tools/command/namesrv/UpdateKvConfigCommand.java	88.88% <ø> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[guyinyou]

lgtm

[zhouxinyu]

IMO, we should rethink the KV ability which makes the NameServer component stateful. Actually, it's not recommended to use this feature in the production environment.

[lizhanhui]

IMO, we should rethink the KV ability which makes the NameServer component stateful. Actually, it's not recommended to use this feature in the production environment.

I agree. Name servers are not a good place to store till they aggregate consensus into their core. Otherwise, troubleshooting will be very challenging in production.

[ferrirW]

IMO, we should rethink the KV ability which makes the NameServer component stateful. Actually, it's not recommended to use this feature in the production environment.

Yes, I understand your concern, but consider current situation:

1. The defaultMQAdminExt provided KV-related interface currently. Theoretically, users can use this capabilities anyway;
2. The MQAdmin tools provided update and delete capabilities, users like me may just need a convenient way to check if the updateKVConfig operation is effective(Of course, this part of the data does not put a huge read/write strain on namesrv)

So I think we should remove all the associated interfaces after we decide that namesrv will no longer play the role of kv.

[mxsm]

LGTM~

[github-actions]

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

[github-actions]

This PR was closed because it has been inactive for 3 days since being marked as stale.