Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6745] Remove redundant variables #6740

Merged
merged 2 commits into from May 17, 2023
Merged

Conversation

haiyanghan
Copy link
Contributor

@haiyanghan haiyanghan commented May 12, 2023

ISSUE #6745

This AtomicInteger variable is meaningless, there is no thread safety issue here, and the variable does not return

@codecov-commenter
Copy link

Codecov Report

Merging #6740 (1e5f8f9) into develop (9d411cf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6740      +/-   ##
=============================================
- Coverage      42.85%   42.84%   -0.02%     
  Complexity      9002     9002              
=============================================
  Files           1113     1113              
  Lines          78615    78614       -1     
  Branches       10229    10229              
=============================================
- Hits           33692    33683       -9     
+ Misses         40701    40699       -2     
- Partials        4222     4232      +10     
Impacted Files Coverage Δ
...client/consumer/store/RemoteBrokerOffsetStore.java 68.75% <100.00%> (-0.28%) ⬇️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @haiyanghan Pleas link to issue.

@haiyanghan
Copy link
Contributor Author

Hi @haiyanghan Pleas link to issue.

ok

@haiyanghan haiyanghan changed the title Remove redundant variables [ISSUE #6745] Remove redundant variables May 12, 2023
@haiyanghan
Copy link
Contributor Author

@mxsm PTAL

@zhouxinyu zhouxinyu merged commit 70480a1 into apache:develop May 17, 2023
10 checks passed
@haiyanghan haiyanghan deleted the develop4 branch May 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants