Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for SubscriptionGroupConfig #6891

Merged
merged 1 commit into from Jun 14, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Jun 12, 2023

Which Issue(s) This PR Fixes

Fixes #6889

Brief Description

Add attribute for SubscriptionGroupConfig like TopicConfig

How Did You Test This Change?

Unit test

@codecov-commenter
Copy link

Codecov Report

Merging #6891 (94f9896) into develop (91d8ee1) will decrease coverage by 0.05%.
The diff coverage is 17.17%.

@@              Coverage Diff              @@
##             develop    #6891      +/-   ##
=============================================
- Coverage      42.67%   42.63%   -0.05%     
+ Complexity      9111     9107       -4     
=============================================
  Files           1125     1127       +2     
  Lines          79875    79910      +35     
  Branches       10383    10387       +4     
=============================================
- Hits           34087    34067      -20     
- Misses         41520    41569      +49     
- Partials        4268     4274       +6     
Impacted Files Coverage Δ
...e/rocketmq/common/SubscriptionGroupAttributes.java 0.00% <0.00%> (ø)
...pache/rocketmq/common/attribute/AttributeUtil.java 0.00% <0.00%> (ø)
...ols/command/consumer/UpdateSubGroupSubCommand.java 0.00% <0.00%> (ø)
...protocol/subscription/SubscriptionGroupConfig.java 50.44% <44.44%> (-0.04%) ⬇️
.../broker/subscription/SubscriptionGroupManager.java 66.46% <80.00%> (+1.36%) ⬆️
...ache/rocketmq/broker/topic/TopicConfigManager.java 54.49% <100.00%> (-4.10%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit aaa4a4b into apache:develop Jun 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add attribute for SubscriptionGroupConfig
4 participants