Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6960]Added Slot formatting sketch comments #6961

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Jun 28, 2023

Which Issue(s) This PR Fixes

Fixes #6960

Brief Description

  • Added Slot formatting sketch comments

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #6961 (d888db3) into develop (87075c2) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6961      +/-   ##
=============================================
- Coverage      42.69%   42.66%   -0.04%     
+ Complexity      9221     9219       -2     
=============================================
  Files           1131     1131              
  Lines          80485    80485              
  Branches       10520    10520              
=============================================
- Hits           34366    34338      -28     
- Misses         41822    41856      +34     
+ Partials        4297     4291       -6     
Impacted Files Coverage Δ
...ain/java/org/apache/rocketmq/store/timer/Slot.java 100.00% <ø> (ø)

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin merged commit 4f840af into apache:develop Jul 5, 2023
10 checks passed
@mxsm mxsm deleted the rocketmq-6960 branch July 5, 2023 03:11
lizhimins pushed a commit to lizhimins/rocketmq that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Added Slot formatting sketch comments
4 participants