Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol server. #7062

Merged
merged 30 commits into from Jul 21, 2023
Merged

[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol server. #7062

merged 30 commits into from Jul 21, 2023

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7061

Brief Description

When we want to support both Remoting protocol and gRPC protocol on the same port, and enable Proxy Protocol, the information for that protocol will be lost during data forwarding. Therefore, we need to re-add the information for that protocol during forwarding.

How Did You Test This Change?

  1. Start proxy server with multi protocol.
  2. Open the proxy protocol server.
  3. Send message with grpc protocol.
  4. Judge the proxy protocol is pass to the grpc server.

徒钟 and others added 30 commits June 7, 2023 13:47
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #7062 (e150946) into develop (440be1e) will increase coverage by 0.15%.
The diff coverage is 13.79%.

@@              Coverage Diff              @@
##             develop    #7062      +/-   ##
=============================================
+ Coverage      42.62%   42.77%   +0.15%     
- Complexity      9230     9294      +64     
=============================================
  Files           1136     1138       +2     
  Lines          80652    81146     +494     
  Branches       10542    10619      +77     
=============================================
+ Hits           34375    34709     +334     
- Misses         41981    42103     +122     
- Partials        4296     4334      +38     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 44.74% <0.00%> (ø)
...cketmq/proxy/processor/ReceiptHandleProcessor.java 35.89% <0.00%> (ø)
...g/protocol/http2proxy/HAProxyMessageForwarder.java 0.00% <0.00%> (ø)
...protocol/http2proxy/Http2ProtocolProxyHandler.java 0.00% <0.00%> (ø)
.../protocol/http2proxy/Http2ProxyBackendHandler.java 0.00% <ø> (ø)
...protocol/http2proxy/Http2ProxyFrontendHandler.java 0.00% <0.00%> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.28% <25.00%> (-0.02%) ⬇️
.../rocketmq/common/utils/ConcurrentHashMapUtils.java 50.00% <42.85%> (-8.34%) ⬇️
...y/service/receipt/DefaultReceiptHandleManager.java 71.52% <66.66%> (ø)
...a/org/apache/rocketmq/proxy/common/RenewEvent.java 92.85% <85.71%> (-7.15%) ⬇️

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@lollipopjin lollipopjin merged commit 90c5382 into apache:develop Jul 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support forward HAProxyMessage for Multi Protocol server.
4 participants