New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol server. #7062
[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol server. #7062
Conversation
…ity of ProtocolNegotiator
…ity of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #7062 +/- ##
=============================================
+ Coverage 42.62% 42.77% +0.15%
- Complexity 9230 9294 +64
=============================================
Files 1136 1138 +2
Lines 80652 81146 +494
Branches 10542 10619 +77
=============================================
+ Hits 34375 34709 +334
- Misses 41981 42103 +122
- Partials 4296 4334 +38
... and 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Which Issue(s) This PR Fixes
Fixes #7061
Brief Description
When we want to support both Remoting protocol and gRPC protocol on the same port, and enable Proxy Protocol, the information for that protocol will be lost during data forwarding. Therefore, we need to re-add the information for that protocol during forwarding.
How Did You Test This Change?