Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6810] Fix the bug of mistakenly deleting data in clientChannelTable when the channel expires #7073

Merged
merged 2 commits into from Jul 27, 2023

Conversation

zd46319
Copy link
Contributor

@zd46319 zd46319 commented Jul 24, 2023

Fix the bug of mistakenly deleting data in clientChannelTable when the channel expires

Which Issue(s) This PR Fixes

Fixes #6810

Brief Description

How Did You Test This Change?

Add test method scanNotActiveChannelWithSameClientId in ProducerManagerTest

@RongtongJin
Copy link
Contributor

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #7073 (cb1e40f) into develop (d797377) will increase coverage by 0.04%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop    #7073      +/-   ##
=============================================
+ Coverage      42.78%   42.82%   +0.04%     
- Complexity      9304     9315      +11     
=============================================
  Files           1138     1138              
  Lines          81252    81254       +2     
  Branches       10636    10637       +1     
=============================================
+ Hits           34762    34796      +34     
+ Misses         42152    42121      -31     
+ Partials        4338     4337       -1     
Files Changed Coverage Δ
...apache/rocketmq/broker/client/ProducerManager.java 73.79% <66.66%> (+1.06%) ⬆️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit d0a69be into apache:develop Jul 27, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants