Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7109] support the mixed topic type #7110

Merged
merged 5 commits into from Aug 3, 2023
Merged

[ISSUE #7109] support the mixed topic type #7110

merged 5 commits into from Aug 3, 2023

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7109

Brief Description

Currently, many users are using a single topic to send messages of different types. However, in the future, there is a desire to exert strict control over message types. Message type validation has already been implemented in the Proxy component. To support the transition of existing users to the Proxy architecture, a new message type called "MIXED" should be introduced to facilitate the migration process.

How Did You Test This Change?

  1. create a topic with MIXED message type.
  2. send messages with different message type, and verify the result.
  3. receive messages in currently and orderly mode, and verify the result.

@dingshuangxi888 dingshuangxi888 changed the title [ISSUE #7109] support mixed topic type [ISSUE #7109] support the mixed topic type Aug 2, 2023
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #7110 (496fa3c) into develop (ab61183) will decrease coverage by 0.02%.
The diff coverage is 73.33%.

@@              Coverage Diff              @@
##             develop    #7110      +/-   ##
=============================================
- Coverage      42.74%   42.72%   -0.02%     
  Complexity      9303     9303              
=============================================
  Files           1139     1139              
  Lines          81259    81262       +3     
  Branches       10636    10637       +1     
=============================================
- Hits           34734    34722      -12     
- Misses         42188    42199      +11     
- Partials        4337     4341       +4     
Files Changed Coverage Δ
...or/validator/DefaultTopicMessageTypeValidator.java 33.33% <0.00%> (-6.67%) ⬇️
...he/rocketmq/proxy/grpc/v2/route/RouteActivity.java 90.00% <88.88%> (-1.13%) ⬇️
...he/rocketmq/common/attribute/TopicMessageType.java 50.00% <100.00%> (+2.17%) ⬆️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk merged commit 3bdabf7 into apache:develop Aug 3, 2023
10 checks passed
@dingshuangxi888 dingshuangxi888 deleted the feature/add_mixed_topic_type branch August 3, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support the MIXED message type
4 participants