Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7111] Remove responseFuture from the responseTable when exception occurs #7112

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

RapperCL
Copy link
Contributor

@RapperCL RapperCL commented Aug 2, 2023

Which Issue(s) This PR Fixes

issue

Fixes #issue_id

Brief Description

How Did You Test This Change?

@RapperCL RapperCL closed this Aug 2, 2023
@RapperCL RapperCL reopened this Aug 2, 2023
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #7112 (b0e4027) into develop (ab61183) will decrease coverage by 0.12%.
Report is 37 commits behind head on develop.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #7112      +/-   ##
=============================================
- Coverage      42.74%   42.63%   -0.12%     
- Complexity      9303     9419     +116     
=============================================
  Files           1139     1152      +13     
  Lines          81259    82356    +1097     
  Branches       10636    10723      +87     
=============================================
+ Hits           34734    35112     +378     
- Misses         42188    42869     +681     
- Partials        4337     4375      +38     
Files Changed Coverage Δ
...rocketmq/remoting/netty/NettyRemotingAbstract.java 51.43% <0.00%> (+0.79%) ⬆️

... and 106 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins changed the title [ISSUE #7111]Remove responseFuture from the responseTable when an exception occurs [ISSUE #7111] Remove responseFuture from the responseTable when exception occurs Aug 29, 2023
@lizhimins lizhimins merged commit bd0e9c0 into apache:develop Aug 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants