[Enhancement #7159] When the user updates the Topic, it will not fail… #7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t fail because of a Broker failure;
HScarb
reviewed
Aug 10, 2023
tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateTopicSubCommand.java
Outdated
Show resolved
Hide resolved
…t fail because of a Broker failure;
lizhimins
requested changes
Aug 11, 2023
RongtongJin
previously approved these changes
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7162 +/- ##
=============================================
+ Coverage 42.46% 42.49% +0.03%
+ Complexity 9348 9346 -2
=============================================
Files 1149 1149
Lines 82042 82052 +10
Branches 10701 10702 +1
=============================================
+ Hits 34843 34872 +29
+ Misses 42836 42814 -22
- Partials 4363 4366 +3
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7159
Brief Description
How Did You Test This Change?