Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7042] throw UnsupportedOperationException after client using TLS Request but Server in Disabled Mode. #7179

Merged
merged 1 commit into from Aug 18, 2023

Conversation

yao-wenbin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7042

Brief Description

How Did You Test This Change?

Test Cases Contains Both TLS Request and Non-TLS Request send by client when Server in DISABLED TLS Mode.

…rRejectsSSLClient test case will throw TooLongFrameException
@codecov-commenter
Copy link

Codecov Report

Merging #7179 (598a6f3) into develop (440be1e) will increase coverage by 1.17%.
Report is 35 commits behind head on develop.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #7179      +/-   ##
=============================================
+ Coverage      42.62%   43.79%   +1.17%     
- Complexity      9230    10202     +972     
=============================================
  Files           1136     1150      +14     
  Lines          80652    89444    +8792     
  Branches       10542    12768    +2226     
=============================================
+ Hits           34375    39175    +4800     
- Misses         41981    45741    +3760     
- Partials        4296     4528     +232     
Files Changed Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 48.00% <0.00%> (+3.26%) ⬆️
.../java/org/apache/rocketmq/common/BrokerConfig.java 23.32% <28.57%> (-3.99%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 58.23% <100.00%> (ø)

... and 92 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 05e7cde into apache:develop Aug 18, 2023
27 of 28 checks passed
@yao-wenbin yao-wenbin deleted the fix-tls-test branch August 18, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TlsTest's serverRejectsSSLClient test case will throw TooLongFrameException
5 participants