Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To config the cardinalityLimit for openTelemetry metrics exporting an… #7196

Merged
merged 2 commits into from Aug 16, 2023

Conversation

lollipopjin
Copy link
Contributor

To config the cardinalityLimit for openTelemetry metrics exporting.

Which Issue(s) This PR Fixes

(1) To config the cardinalityLimit for openTelemetry metrics exporting, or we may encounter warning like this:

WARNING: Instrument rocketmq_storage_size has exceeded the maximum allowed accumulations (2000).

Brief Description

(1) Introduce a higher version of opentelemetry.
(2) allow user to config metricsOtelCardinalityLimit in brokerconfig.

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7196 (d93fb81) into develop (55e0cdb) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 21.56%.

@@              Coverage Diff              @@
##             develop    #7196      +/-   ##
=============================================
- Coverage      42.47%   42.46%   -0.02%     
+ Complexity      9352     9347       -5     
=============================================
  Files           1149     1149              
  Lines          82046    82064      +18     
  Branches       10701    10701              
=============================================
- Hits           34848    34846       -2     
- Misses         42837    42857      +20     
  Partials        4361     4361              
Files Changed Coverage Δ
.../rocketmq/broker/metrics/BrokerMetricsManager.java 11.27% <0.00%> (-0.62%) ⬇️
...che/rocketmq/broker/metrics/PopMetricsManager.java 28.97% <0.00%> (+0.26%) ⬆️
...q/controller/metrics/ControllerMetricsManager.java 19.37% <0.00%> (ø)
...ketmq/remoting/metrics/RemotingMetricsManager.java 11.11% <0.00%> (+0.30%) ⬆️
...org/apache/rocketmq/store/DefaultMessageStore.java 46.94% <ø> (ø)
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...etmq/store/metrics/DefaultStoreMetricsManager.java 18.01% <ø> (ø)
...ketmq/store/plugin/AbstractPluginMessageStore.java 0.00% <ø> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.23% <25.00%> (-0.02%) ⬇️
...pache/rocketmq/tieredstore/TieredMessageStore.java 73.70% <100.00%> (ø)
... and 1 more

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lizhimins
lizhimins previously approved these changes Aug 16, 2023
@lizhimins lizhimins merged commit 50d1050 into apache:develop Aug 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants