Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7246] Add expireAfterAccess for cache #7247

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Aug 24, 2023

Rename ProxyConfig ExpiredInSeconds to RefreshSeconds

Which Issue(s) This PR Fixes

Fixes #7246

Brief Description

Add expireAfterAccess for cache

How Did You Test This Change?

Rename ProxyConfig ExpiredInSeconds to RefreshSeconds
@codecov-commenter
Copy link

Codecov Report

Merging #7247 (1cba84b) into develop (72d796f) will increase coverage by 0.13%.
Report is 9 commits behind head on develop.
The diff coverage is 70.37%.

@@              Coverage Diff              @@
##             develop    #7247      +/-   ##
=============================================
+ Coverage      42.46%   42.59%   +0.13%     
- Complexity      9353     9405      +52     
=============================================
  Files           1149     1152       +3     
  Lines          82111    82352     +241     
  Branches       10703    10723      +20     
=============================================
+ Hits           34868    35080     +212     
- Misses         42882    42889       +7     
- Partials        4361     4383      +22     
Files Changed Coverage Δ
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 54.42% <55.55%> (+0.22%) ⬆️
...proxy/service/metadata/ClusterMetadataService.java 78.78% <100.00%> (+0.66%) ⬆️
...ocketmq/proxy/service/route/TopicRouteService.java 73.17% <100.00%> (+1.37%) ⬆️

... and 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 7e01852 into apache:develop Aug 25, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add expireAfterAccess for cache
6 participants