Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7305] Fix metrics and transactional module not shutdown while broker offline cause coredump #7307

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Sep 6, 2023

Which Issue(s) This PR Fixes

Fixes #7305

Brief Description

How Did You Test This Change?

@lizhimins lizhimins changed the title [ISSUE #7305] Fix metrics and transactional not shutdown cause broker coredump [ISSUE #7305] Fix metrics and transactional module not shutdown while broker offline cause coredump Sep 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7307 (73e16e4) into develop (d000ef9) will increase coverage by 0.02%.
Report is 3 commits behind head on develop.
The diff coverage is 70.17%.

@@              Coverage Diff              @@
##             develop    #7307      +/-   ##
=============================================
+ Coverage      42.63%   42.65%   +0.02%     
- Complexity      9453     9468      +15     
=============================================
  Files           1151     1151              
  Lines          82669    82705      +36     
  Branches       10771    10778       +7     
=============================================
+ Hits           35246    35280      +34     
+ Misses         43018    43017       -1     
- Partials        4405     4408       +3     
Files Changed Coverage Δ
...ache/rocketmq/broker/topic/TopicConfigManager.java 56.68% <0.00%> (-0.34%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.96% <50.00%> (+0.02%) ⬆️
...saction/queue/TransactionalMessageServiceImpl.java 52.68% <50.00%> (+1.78%) ⬆️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.58% <71.42%> (+0.58%) ⬆️
...ocketmq/broker/processor/AdminBrokerProcessor.java 24.37% <92.30%> (+0.30%) ⬆️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins merged commit 37017db into apache:develop Sep 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix metrics and transactional not shutdown cause broker coredump
3 participants