Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7318] Add the configuration of topicQueueLock number to better support different queue nums scenarios #7317

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Sep 7, 2023

Which Issue(s) This PR Fixes

Fixes #7318

Brief Description

Add the configuration of topicQueueLock number to better support different queue nums scenarios

How Did You Test This Change?

@RongtongJin RongtongJin changed the title Add the configuration of topicQueueLock number to better support different queue nums scenarios [ISSUE #7318] Add the configuration of topicQueueLock number to better support different queue nums scenarios Sep 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7317 (158f3d2) into develop (e11e294) will decrease coverage by 0.08%.
The diff coverage is 81.81%.

@@              Coverage Diff              @@
##             develop    #7317      +/-   ##
=============================================
- Coverage      42.69%   42.61%   -0.08%     
+ Complexity      9474     9462      -12     
=============================================
  Files           1152     1152              
  Lines          82721    82731      +10     
  Branches       10781    10782       +1     
=============================================
- Hits           35315    35258      -57     
- Misses         42997    43060      +63     
- Partials        4409     4413       +4     
Files Changed Coverage Δ
...ache/rocketmq/store/config/MessageStoreConfig.java 56.59% <50.00%> (-0.04%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 58.18% <100.00%> (ø)
...java/org/apache/rocketmq/store/TopicQueueLock.java 66.66% <100.00%> (-33.34%) ⬇️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit a9e3532 into apache:develop Sep 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add the configuration of topicQueueLock number to better support different topic nums scenarios
5 participants