Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7330] Add goaway and reconnection mechanism #7331

Merged
merged 8 commits into from Oct 10, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Sep 8, 2023

Which Issue(s) This PR Fixes

Fixes #7330

Brief Description

Add goaway response code when the server is shutting down and client reconnection and transparent retry mechanism.

How Did You Test This Change?

Existing unit test.

@drpmma drpmma removed the Draft label Oct 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #7331 (9cde118) into develop (8415608) will decrease coverage by 0.03%.
Report is 5 commits behind head on develop.
The diff coverage is 35.50%.

@@              Coverage Diff              @@
##             develop    #7331      +/-   ##
=============================================
- Coverage      42.70%   42.67%   -0.03%     
+ Complexity      9480     9478       -2     
=============================================
  Files           1150     1150              
  Lines          82687    82814     +127     
  Branches       10749    10768      +19     
=============================================
+ Hits           35311    35344      +33     
- Misses         42973    43050      +77     
- Partials        4403     4420      +17     
Files Coverage Δ
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 23.27% <100.00%> (+0.10%) ⬆️
...pache/rocketmq/remoting/protocol/ResponseCode.java 0.00% <ø> (ø)
.../java/org/apache/rocketmq/client/ClientConfig.java 63.76% <71.42%> (-0.10%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 57.48% <33.33%> (+0.68%) ⬆️
...che/rocketmq/remoting/netty/NettyServerConfig.java 50.00% <37.50%> (-1.62%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 57.14% <14.28%> (+1.21%) ⬆️
...che/rocketmq/remoting/netty/NettyClientConfig.java 47.56% <25.00%> (-3.87%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 45.74% <31.25%> (-0.55%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 40.53% <33.33%> (-2.22%) ⬇️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

RongtongJin
RongtongJin previously approved these changes Oct 10, 2023
…rLifecycleListener (apache#7432)

* Fix flaky test of DLedgerControllerTest#testBrokerLifecycleListener
@drpmma drpmma merged commit 4acb43e into apache:develop Oct 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [ISSUE #7296] [TASK 3] Add goaway and reconnection mechanism
4 participants