Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7531] Clear POP_CK when sending messages #7532

Merged
merged 1 commit into from Nov 6, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Nov 3, 2023

Which Issue(s) This PR Fixes

Fixes #7531

Brief Description

How Did You Test This Change?

Add Integration test.

@xdkxlk xdkxlk marked this pull request as draft November 3, 2023 08:12
@codecov-commenter
Copy link

Codecov Report

Merging #7532 (9adcd46) into develop (46962c2) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #7532      +/-   ##
=============================================
+ Coverage      42.97%   43.07%   +0.09%     
- Complexity      9677     9695      +18     
=============================================
  Files           1158     1158              
  Lines          83987    83988       +1     
  Branches       10917    10917              
=============================================
+ Hits           36093    36177      +84     
+ Misses         43399    43315      -84     
- Partials        4495     4496       +1     
Files Coverage Δ
...main/java/org/apache/rocketmq/store/CommitLog.java 58.97% <100.00%> (+0.19%) ⬆️

... and 30 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@xdkxlk xdkxlk marked this pull request as ready for review November 3, 2023 09:43
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 00965d8 into apache:develop Nov 6, 2023
9 of 10 checks passed
@xdkxlk xdkxlk deleted the develop-7531 branch November 7, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The PopCk is incorrect after forwarding messages to another broker
5 participants