Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7545] [RIP-65] Support efficient random index for massive messages #7546

Merged
merged 3 commits into from Nov 21, 2023

Conversation

lizhimins
Copy link
Member

…sages

Which Issue(s) This PR Fixes

Support #7545

Brief Description

How Did You Test This Change?

@lizhimins lizhimins changed the title [ISSUE #7545] [RIP-65] Support efficient random index for massive mes… [ISSUE #7545] [RIP-65] Support efficient random index for massive messages Nov 8, 2023
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (46962c2) 42.97% compared to head (a1afabe) 43.22%.
Report is 10 commits behind head on develop.

Files Patch % Lines
...che/rocketmq/tieredstore/index/IndexStoreFile.java 77.50% 35 Missing and 19 partials ⚠️
.../rocketmq/tieredstore/index/IndexStoreService.java 74.86% 32 Missing and 14 partials ⚠️
...che/rocketmq/tieredstore/TieredMessageFetcher.java 0.00% 28 Missing ⚠️
...main/java/org/apache/rocketmq/store/CommitLog.java 59.09% 7 Missing and 11 partials ⚠️
...a/org/apache/rocketmq/store/MessageExtEncoder.java 78.26% 3 Missing and 7 partials ⚠️
.../java/org/apache/rocketmq/store/MultiDispatch.java 87.09% 0 Missing and 4 partials ⚠️
...rocketmq/common/message/MessageExtBrokerInner.java 25.00% 3 Missing ⚠️
...org/apache/rocketmq/common/utils/MessageUtils.java 88.00% 0 Missing and 3 partials ⚠️
...cketmq/tieredstore/file/TieredFlatFileManager.java 72.72% 1 Missing and 2 partials ⚠️
...pache/rocketmq/store/queue/MultiDispatchUtils.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7546      +/-   ##
=============================================
+ Coverage      42.97%   43.22%   +0.25%     
- Complexity      9677     9781     +104     
=============================================
  Files           1158     1162       +4     
  Lines          83987    84223     +236     
  Branches       10917    10933      +16     
=============================================
+ Hits           36093    36408     +315     
+ Misses         43399    43297     -102     
- Partials        4495     4518      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 63130f5 into apache:develop Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants