[RIP-11]add SessionManager and WillMessageService; finish CONNECT/DISCONNECT logic #755
Conversation
|
|
||
| this.sendMessageExecutor = ThreadUtils.newThreadPoolExecutor( | ||
| snodeConfig.getSnodeSendMessageMinPoolSize(), |
There was a problem hiding this comment.
@xiangwangcheng it seems that you modified some codes that has nothing to do with this function, and just modified the code format, which will make the code review a little difficult. Could you download a rocketmq code style from our website: https://rocketmq.apache.org/docs/code-guidelines/?
There was a problem hiding this comment.
@duhenglucky OK. I will apply the rmq code style.
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class Session { |
There was a problem hiding this comment.
It seems that we can use org.apache.rocketmq.snode.client.Client instead.
| import org.apache.rocketmq.logging.InternalLoggerFactory; | ||
| import org.apache.rocketmq.snode.SnodeController; | ||
|
|
||
| public class SessionManagerImpl { |
There was a problem hiding this comment.
Could you achieve this by implementing the ClientManagerImpl class?
| if (message2MessageEncodeDecode != null) { | ||
| mqttMessage = message2MessageEncodeDecode.encode(msg); | ||
| } | ||
| out.add(mqttMessage); |
There was a problem hiding this comment.
Here,if the return value of message2MessageEncodeDecode is null,then the out object list will be add into a null value.You may add some judgement logic here.
| mqttHeader.setSessionPresent(variableHeader.isSessionPresent()); | ||
|
|
||
| requestCommand = RemotingCommand | ||
| .createRequestCommand(1000, mqttHeader); |
There was a problem hiding this comment.
The 1000 request code could be added into RequestCode.And here，you can using the RequestCode value.
There was a problem hiding this comment.
I can't do that because RequestCode.java is in Common module and Remoting module does not dependent on Common module.
| mqttHeader.setMessageId(variableHeader.messageId()); | ||
|
|
||
| requestCommand = RemotingCommand | ||
| .createRequestCommand(1000, mqttHeader); |
There was a problem hiding this comment.
Here,it's also as the same as before.
| mqttHeader.setMessageId(variableHeader.messageId()); | ||
|
|
||
| requestCommand = RemotingCommand | ||
| .createRequestCommand(1000, mqttHeader); |
There was a problem hiding this comment.
Here,it's also as the same as before.
xiangwangcheng
force-pushed
the
snode
branch
2 times, most recently
from
c722a44
to
3c95e3c
Compare
…de between MqttMessage and RemotingCommand 3.add topic<--->subscription data 4.add subscribe and suback logic
xiangwangcheng
force-pushed
the
snode
branch
from
3c95e3c
to
2f46644
Compare
What is the purpose of the change
Mqtt protocol support
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.