Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7551] Reuse helper methods from Netty to free direct byte buffer #7550

Merged
merged 3 commits into from Nov 13, 2023

Conversation

lizhanhui
Copy link
Contributor

@lizhanhui lizhanhui commented Nov 10, 2023

Make codebase JDK 9+ compatible

fix #7551

…debase JDK 9+ compatible

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@lizhanhui lizhanhui changed the title Reuse helper methods from Netty to free direct byte buffer [ISSUE #7551] Reuse helper methods from Netty to free direct byte buffer Nov 10, 2023
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhanhui lizhanhui merged commit 1be5ebc into develop Nov 13, 2023
10 checks passed
@lizhanhui lizhanhui deleted the free_direct_byte_buffer branch November 13, 2023 01:45
Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Git rid of internal sun.nio.ch.DirectBuffer
5 participants