Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7702]Fix ascii check for ppv2 tls. #7703

Merged

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7702

Brief Description

When parsing the PPV2 protocol and setting the TLS contents as gRPC attributes, gRPC will log the following messages. To avoid excessive logging, filter out content that does not conform to ASCII.

How Did You Test This Change?

  1. Open the ppv2 protocol
  2. Send ppv2 message with tls data [61, 12, 109]
  3. Check the log

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (59e8f9b) 43.17% compared to head (5d6d28d) 43.16%.

Files Patch % Lines
...a/org/apache/rocketmq/common/utils/BinaryUtil.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7703      +/-   ##
=============================================
- Coverage      43.17%   43.16%   -0.02%     
+ Complexity      9812     9804       -8     
=============================================
  Files           1165     1165              
  Lines          84542    84542              
  Branches       10979    10979              
=============================================
- Hits           36502    36490      -12     
- Misses         43497    43507      +10     
- Partials        4543     4545       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 2c5bc14 into apache:develop Dec 27, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix ascii check for ppv2 tls
3 participants