Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7774] Make the handle of ppv2 tlv more extendable #7775

Merged

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7774

Brief Description

In the PPV2 protocol, TLV data is generally customized and needs to have the capability for extension.

How Did You Test This Change?

customize the PPV2 TLV data, and extends the handler for data.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6d75134) 43.21% compared to head (9ea5734) 43.26%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...etmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java 55.55% 3 Missing and 1 partial ⚠️
...g/protocol/http2proxy/HAProxyMessageForwarder.java 62.50% 3 Missing ⚠️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 66.66% 2 Missing and 1 partial ⚠️
...protocol/http2proxy/Http2ProtocolProxyHandler.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7775      +/-   ##
=============================================
+ Coverage      43.21%   43.26%   +0.04%     
- Complexity      9859     9873      +14     
=============================================
  Files           1171     1173       +2     
  Lines          85025    85030       +5     
  Branches       11015    11013       -2     
=============================================
+ Hits           36744    36784      +40     
+ Misses         43717    43687      -30     
+ Partials        4564     4559       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 92e058c into apache:develop Jan 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make the handle of ppv2 tlv more extendable
3 participants