Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7622] Revise the measurement method of GROUP_GET_LATENCY to reveal its intended semantics #7808

Merged
merged 1 commit into from Feb 4, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Jan 31, 2024

Which Issue(s) This PR Fixes

Fixes #7622

Brief Description

Revise the measurement method of GROUP_GET_LATENCY to reveal its intended semantics

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (06e22b4) 42.93% compared to head (2128d45) 43.01%.

Files Patch % Lines
...ocketmq/broker/processor/PeekMessageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7808      +/-   ##
=============================================
+ Coverage      42.93%   43.01%   +0.07%     
- Complexity      9905     9918      +13     
=============================================
  Files           1190     1190              
  Lines          85934    85934              
  Branches       11070    11070              
=============================================
+ Hits           36898    36962      +64     
+ Misses         44476    44393      -83     
- Partials        4560     4579      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShannonDing ShannonDing merged commit cb7fa3e into apache:develop Feb 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The current statistical method for the GROUP_GET_LATENCY metric fails to reveal its intended semantics
4 participants