Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7813] setStartDetectorEnable Not effective #7825

Merged
merged 1 commit into from Feb 7, 2024

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Feb 6, 2024

Which Issue(s) This PR Fixes

Fixes #7813

Brief Description

由于StartDetectorEnable 在构造函数里面只初始化了一次,所以后续再set的时候, 已经不会生效了。

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8df53df) 42.94% compared to head (f805f0d) 42.99%.
Report is 11 commits behind head on develop.

Files Patch % Lines
...he/rocketmq/client/producer/DefaultMQProducer.java 0.00% 3 Missing ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 50.00% 2 Missing ⚠️
...mq/client/impl/producer/DefaultMQProducerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7825      +/-   ##
=============================================
+ Coverage      42.94%   42.99%   +0.04%     
- Complexity      9902     9921      +19     
=============================================
  Files           1190     1190              
  Lines          85930    85982      +52     
  Branches       11070    11078       +8     
=============================================
+ Hits           36906    36964      +58     
+ Misses         44458    44439      -19     
- Partials        4566     4579      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit f525a34 into apache:develop Feb 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] setStartDetectorEnable Not effective
4 participants