Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP 11]Fix some test cases of msg trace part,fix a issue of acl part in 4.4.0, and optimize and adjust codes on Snode. #785

Merged
merged 3 commits into from
Feb 17, 2019

Conversation

zongtanghu
Copy link
Contributor

What is the purpose of the change

fix issue and adjust some codes for msg trace,acl and http2 part.

Brief changelog

1.resolve some issue about test case of msg trace.
2.fix a issue which have been found in 4.4.0 version.
3.adjust some codes in http2 part and.
4.add SEND_BATCH_MESSAGE request code to related processor.

Verifying this change

I have already verified this change in my local enviroment.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zongtanghu zongtanghu changed the title Snode [RIP 11]Fix some test cases of msg trace part,fix a issue of acl part in 4.4.0, and optimize and adjust codes on Snode. Feb 16, 2019
@duhenglucky duhenglucky merged commit e7b7107 into apache:snode Feb 17, 2019
@ShannonDing ShannonDing added this to the 5.0.0 milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants