build: fix workflow and skip failed test for auth module on mac #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HScarb
force-pushed
the
fix/workflow
branch
2 times, most recently
from
68b54d4
to
69f6c21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8068 +/- ##
=============================================
- Coverage 42.88% 42.82% -0.06%
- Complexity 10348 10349 +1
=============================================
Files 1270 1270
Lines 88673 88677 +4
Branches 11398 11398
=============================================
- Hits 38029 37979 -50
- Misses 45950 46001 +51
- Partials 4694 4697 +3 ☔ View full report in Codecov by Sentry. |
HScarb
changed the title
HScarb
changed the title
RongtongJin
approved these changes
Apr 29, 2024
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
May 7, 2024
… on mac (apache#8068) * build: fix coverage workflow * Skipping some tests under the auth package on Mac * build: fix test imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8075
Brief Description
add codecov token in coverage.yml from https://app.codecov.io/github/apache/rocketmq/settings
skip tests for auth module that can't pass on mac because of rocksdbjni error
How Did You Test This Change?
Coverage / calculate-coverage (pull_request) Successful in 24m