Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8090] Optimize isSetEqual for DefaultLitePullConsumerImpl #8091

Merged
merged 4 commits into from
May 8, 2024

Conversation

Willhow-Gao
Copy link
Contributor

Fixes #8090

  1. 优化了DefaultLitePullConsumerImpl#isSetEqual方法,减少了循环次数和不正确的判断。并添加了isSetEqual方法的单元测试
  2. 订正了一个单词拼写错误

How Did You Test This Change?
添加了单元测试验证isSetEqual方法是否符合预期

Comment on lines 14 to 17
/**
* @author Willhow
* @since 2024/5/3
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author information needs to be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

作者信息需要删除

already removed. Also revised code style and added license comments

@RongtongJin
Copy link
Contributor

Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:1: Line does not match expected header line of '/*'. [RegexpHeader]
Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:15: Recommended remove @author tag in javadoc! [RegexpSingleline]
Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:60:91: '{' is not preceded with whitespace. [WhitespaceAround]
Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:68:91: '{' is not preceded with whitespace. [WhitespaceAround]
Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:76:91: '{' is not preceded with whitespace. [WhitespaceAround]

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 42.84%. Comparing base (b39f65e) to head (d656b4c).
Report is 12 commits behind head on develop.

Files Patch % Lines
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 40.00% 1 Missing and 2 partials ⚠️
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8091      +/-   ##
=============================================
- Coverage      42.88%   42.84%   -0.05%     
- Complexity     10348    10350       +2     
=============================================
  Files           1270     1270              
  Lines          88673    88680       +7     
  Branches       11398    11397       -1     
=============================================
- Hits           38029    37994      -35     
- Misses         45950    45989      +39     
- Partials        4694     4697       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins
Copy link
Member

合并一下 develop 重新提交一下,develop 有一些单测的修复

@Willhow-Gao
Copy link
Contributor Author

合并一下 develop 重新提交一下,develop 有一些单测的修复

merge develop了

@cserwen cserwen changed the title [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [ISSUE #8090] Optimize isSetEqual for DefaultLitePullConsumerImpl May 7, 2024
@RongtongJin RongtongJin merged commit f0c243d into apache:develop May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] 方法DefaultLitePullConsumerImpl#isSetEqual可以优化
6 participants