Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8103] Fix SimpleSubscriptionData equal #8104

Merged
merged 1 commit into from
May 7, 2024

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented May 7, 2024

Which Issue(s) This PR Fixes

Fixes #8103

Brief Description

Fix SimpleSubscriptionData equal

How Did You Test This Change?

unit test

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (b39f65e) to head (e8d2e3a).
Report is 14 commits behind head on develop.

Files Patch % Lines
.../protocol/subscription/SimpleSubscriptionData.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8104      +/-   ##
=============================================
- Coverage      42.88%   42.86%   -0.03%     
- Complexity     10348    10362      +14     
=============================================
  Files           1270     1270              
  Lines          88673    88690      +17     
  Branches       11398    11399       +1     
=============================================
- Hits           38029    38014      -15     
- Misses         45950    45981      +31     
- Partials        4694     4695       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma merged commit dcf892a into apache:develop May 7, 2024
10 checks passed
@drpmma drpmma deleted the feature/fix-SimpleSubscriptionData branch May 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix the equal of SimpleSubscriptionData
4 participants