Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody #855

Closed
wants to merge 1 commit into from

Conversation

ro9er
Copy link
Contributor

@ro9er ro9er commented Feb 22, 2019

What is the purpose of the change

Add test case for org.apache.rocketmq.common.protocol.body.QueryCorrectionOffsetBody.java and org.apache.rocketmq.common.protocol.body.ResetOffsetBody.java

Brief changelog

Add test case for QueryCorrectionOffsetBody & ResetOffsetBody to test the correction of the serialization and deserialization.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

1. 添加QueryCorrectionOffsetBody测试
2. 添加ResetOffsetBody测试
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 44.965% when pulling c1b8ec7 on ro9er:1.1.201902221628_test into 8f37ff2 on apache:master.

@ro9er ro9er changed the title Add test case for QueryCorrectionOffsetBody & ResetOffsetBody [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody Feb 25, 2019
@ro9er ro9er closed this Feb 26, 2019
@ro9er
Copy link
Contributor Author

ro9er commented Feb 26, 2019

I will open another pr for develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants