Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates (JDK 21 compatibility) #126

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Dependency updates (JDK 21 compatibility) #126

merged 1 commit into from
Jul 3, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jun 22, 2023

Mostly minor dependency updates which should allow roller to run on the upcoming JDK 21.

The only major update was guice, guice 6.x and 7.x are nearly identical taken from doc:

The Guice 6.0 servlet & persist extensions only support the javax.servlet and javax.persistence namespaces respectively. If compatibility with jakarta.servlet or jakarta.persistence is required, use Guice 7.0.

Guice 7.0 removes support for javax.inject, javax.servlet and javax.persistence. Other than the namespace changes, Guice 6.0 & Guice 7.0 are identical.

updated from 5.x to 6.0 for now.

snoopdave
snoopdave approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge when you're ready.

@mbien
Copy link
Member Author

mbien commented Jul 3, 2023

@snoopdave thanks for taking a look -> merging

@mbien mbien merged commit 94b2f72 into apache:master Jul 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoopdave snoopdave snoopdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mbien @snoopdave