Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate tz #134

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Validate tz #134

merged 8 commits into from
Feb 10, 2024

Conversation

snoopdave
Copy link
Contributor

Add some input validations and prepare for next release which will be 6.1.3.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually: the cleanup would need to happen in the constructor too I believe, since this would sideline the setters otherwise.

(constructor could call the setter potentially)

@snoopdave snoopdave merged commit 03919b6 into master Feb 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants