Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse referrer URL instead of using string value directly. #90

Merged
merged 7 commits into from Jul 4, 2021

Conversation

snoopdave
Copy link
Contributor

@snoopdave snoopdave commented May 31, 2021

This PR changes the logic for processing referers so that the referer URL is validated before storage.

@mbien
Copy link
Member

mbien commented May 31, 2021

LGTM, small remark for your consideration:

org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flow. Lib is already in the dependencies.

example snippet in doc

@snoopdave
Copy link
Contributor Author

LGTM, small remark for your consideration:

org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flow. Lib is already in the dependencies.

example snippet in doc

Thanks for the review. I switched over to URLValidator as you suggested.

@mbien
Copy link
Member

mbien commented Jun 6, 2021

@snoopdave excellent. LGTM. (the fixed test looks good too, I was wondering if it was only failing on my machine)

@mbien
Copy link
Member

mbien commented Jun 20, 2021

4c55a62 regexp eval replacement logic looks good to me

@snoopdave snoopdave merged commit 58e61b0 into apache:master Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants