Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDL Components do not accept dynamically changing className after native MDL library upgrade #222

Closed
piotrzarzycki21 opened this issue May 4, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@piotrzarzycki21
Copy link
Member

Each MDL component is passing through upgrading which in some cases adding additional container which is not part of Royale.

Having following code:

<js:View>
     <mdl:NavigationLayout currentState="Examples" className.Examples="examplesBackground"> 
    </mdl:NavigationLayout> 
</js:View>

Should be translated to:

<div>
   <div class="examplesBackground"></div>
</div>

BUT after translation it looks like that:

- This ELEMENT is not a Royale creation. It doesn't have royale_wrapper.

In the results of switching to between different states which are changing className, UIBase is calling property parent. Unfortunately since parent is not an Royale component parent is undefined all the time.

<mdl:NavigationLayout currentState="Snippets" className.Snippets="snippetsBackground"> 
    </mdl:NavigationLayout> 
@piotrzarzycki21 piotrzarzycki21 self-assigned this May 4, 2018
@piotrzarzycki21 piotrzarzycki21 added this to the v0.9.4 milestone May 4, 2018
piotrzarzycki21 added a commit that referenced this issue May 4, 2018
carlosrovira added a commit that referenced this issue May 5, 2018
* develop:
  MDL: Fix issue where parent during changes of component className was undefined (reference #222)
  Update version
@piotrzarzycki21 piotrzarzycki21 modified the milestones: v0.9.4, v0.9.3 May 12, 2018
@piotrzarzycki21
Copy link
Member Author

The general solution is ready. I have applied fix for NavigationLayout only. It will be applied to other places if needed. I'm closing that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant