Moved some (non-MX) changes from PR #1127. Add support for XML data … #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data in several areas, especially around sorting and grids.
estanglerbm
added a commit
to estanglerbm/royale-asjs
that referenced
this pull request
Sep 19, 2021
…ta in several areas, especially around sorting and grids.
|
Thanks. I'm not going to be available to continue this discussion for the next week plus. I'll try to come up with some suggestions then. |
|
Sorry I forgot to look at this. Besides PAYG concerns, this does not look like it will work with minification without exports. I'll try to see what I can do to make this work while addressing those two concerns... |
|
Do you have a sample project for testing these changes that I can use for some refactoring? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in several areas, especially around sorting and grids.
Based on feedback from @Harbs.