Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EffectEvent and IEffectInstance Added #153

Merged
merged 13 commits into from Apr 17, 2018

Conversation

alinakazi
Copy link
Member

mx.effects.IEffectInstance and mx.events,EffectEvent added

PropertyChanges FlexSDK->Royale
Update PropertyChanges.as
IEffectInstance.as Copied FlexSDK->Royale
Update IEffectInstance.as
EffectEvent Copied FlexSDK->Royale
Update EffectEvent.as
Update MXRoyaleClasses.as for IEffectInstance,EffectEvent,PropertyChanges
@carlosrovira carlosrovira added this to To Do in Emulation Components via automation Apr 9, 2018
Copy link
Contributor

@aharui aharui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, there are APIs in here that are not being used by your app, like removeFocusRing, reverse, resume. These should be commented out or removed. Please check against the list from the API report. There may be more API than the three I mentioned

@alinakazi alinakazi mentioned this pull request Apr 16, 2018
@aharui
Copy link
Contributor

aharui commented Apr 16, 2018

Is there a reason PropertyChanges.as is in this set of files? I don't see a need for it.

@alinakazi
Copy link
Member Author

PropertyChanges.as File Deleted & Reference removed from IEffectInstance.as and MXRoyaleClasses.as

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants