Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few chart classes #221

Merged
merged 19 commits into from Jun 4, 2018
Merged

Conversation

LHR07-DBz
Copy link
Contributor

mx.charts.chartClasses.CartesianChart
mx.charts.chartClasses.IAxis
mx.charts.PlotChart
mx.charts.series.PieSeries
mx.charts.series.PlotSeries
mx.charts.series.items.PieSeriesItem
mx.charts.AreaChart

@alinakazi
Copy link
Member

I don't see a need to emulate CartesianChart ,IAxis,ModuleManagerGlobals.
Donot change property/method public to private . add @royalesuppresspublicvarwarning for reference see other files in MXRoyale Branch

@LHR07-DBz
Copy link
Contributor Author

CartesianChart removed but IAxis is required as argument for horizontalAxis method so it is retained. Rest all files are updated as per comments

@alinakazi
Copy link
Member

Like setStyle & width are properties/methods required in PlotChart and these are extended from UIComponent. IMO PlotChart should extend UIComponent. Again this is just an example.

@aharui please comment on it further.

@aharui
Copy link
Contributor

aharui commented May 16, 2018

Alina is correct that just about every class will need to extend something. However, in this case PlotChart should extend ChartBase. The way to determine this is:

  1. Look at the flex-sdk version of the class (in this case PlotChart.as)
  2. See if the base class (in this case CartesianChart) is listed in the API report. If so, use that base class, if not, open the flex-sdk version of the base class (in this case CartesianChart.as)
  3. See if its base class (in this case ChartBase) is listed in the API report). In this case, it is, so PlotChart should extend ChartBase.

Loop through 2 & 3 until you find a base class in the report. The loop for ui controls should end with UIComponent if not some subclass of UIComponent.

@LHR07-DBz
Copy link
Contributor Author

Updated AreaChart.as, PlotChart.as, PlotSeries.as, PieSeries.as & PieSeriesItem.as files as instructed

@alinakazi
Copy link
Member

In PlotChart dataTipFunction is a method that is extended from ChartBase so this method should be added to ChartBase . Again this is just an example. We need to compile our D-Biz Application for that every property or method that is used by our D-Biz Application should be added to emulated components.

@alinakazi
Copy link
Member

Do not copy ChartBase from flex-sdk & make changes from beginning .
Add/Copy methods in existing ChartBase that is already emulated.

Moved references from MXRoyaleClasses.as to mx-manifest.xml
Moved references from MXRoyaleClasses.as to mx-manifest.xml
@LHR07-DBz
Copy link
Contributor Author

Moved references from MXRoyaleClasses.as to mx-manifest.xml

@alinakazi alinakazi merged commit 7fec78b into apache:feature/MXRoyale Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants