Base64Encoder, Base64JSWrapper, TextEncoderLiteWrapper classes added #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2018 23:29
|
@piotrzarzycki21 may you pls check the PR, some of your comments are not included because i need more advices. |
There was a problem hiding this comment.
The only comment which I have is that. Shouldn't all those encoders should be in Basic or Core? Is it specified only to emulation ? @aharui
|
Sure, at some point we should refactor to have a Basic version. It isn't obvious to me how to do it, so I think we should accept the PR as-is and find a volunteer to refactor later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64Encoder modified for emulation project and Base64JSWrapper, TextEncoderLiteWrapper javascript classes added