Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMZA-2187: Remove startpoint registration API from SystemConsumer. #1022

Merged
merged 1 commit into from May 8, 2019
Merged

SAMZA-2187: Remove startpoint registration API from SystemConsumer. #1022

merged 1 commit into from May 8, 2019

Conversation

shanthoosh
Copy link
Contributor

No description provided.

@shanthoosh
Copy link
Contributor Author

shanthoosh commented May 8, 2019 •
edited

@dnishimura
Please take a look when you have a chance.
In a immediate follow-up PR, OffsetManager will be wired in with newer way of startpoint to offset resolution.

dnishimura
dnishimura approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@dnishimura dnishimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@shanthoosh shanthoosh merged commit edaaec2 into apache:master May 8, 2019
prateekm pushed a commit to prateekm/samza that referenced this pull request May 12, 2019
@shanthoosh @prateekm
Remove register(ssp, startpoint) API from SystemConsumer and its usag…
babd0ef 
…es. (apache#1022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnishimura dnishimura dnishimura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shanthoosh @dnishimura