Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-2313: Adding validation for Samza Sql statements. #1148

Merged
merged 6 commits into from
Sep 3, 2019

Conversation

atoomula
Copy link
Contributor

No description provided.

Copy link
Contributor

@srinipunuru srinipunuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. It would be good if you could add a UT to protect the string parsing logic.

Copy link
Contributor

@srinipunuru srinipunuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoomula atoomula merged commit 97afd3f into apache:master Sep 3, 2019
@atoomula atoomula deleted the validate branch September 3, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants