Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMZA-2364: Include the localized resource lib directory in the classpath of SamzaContainer #1207

Merged
merged 3 commits into from
Nov 5, 2019
Merged

SAMZA-2364: Include the localized resource lib directory in the classpath of SamzaContainer #1207

merged 3 commits into from
Nov 5, 2019

Conversation

shanthoosh
Copy link
Contributor

@shanthoosh shanthoosh commented Nov 4, 2019 •
edited
Loading

No description provided.

@shanthoosh shanthoosh changed the title SAMZA-2364: Include the localized resource lib directory in the class… SAMZA-2364: Include the localized resource lib directory in the classpath of SamzaContainer Nov 4, 2019
@shanthoosh
Copy link
Contributor Author

@srinipunuru @atoomula @abhishekshivanna
Please take a look when you get a chance.

atoomula
atoomula approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@atoomula atoomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for review from Abhishek.

@abhishekshivanna
Copy link
Contributor

Looks good to me.
nit: can rename LOCALIZED_RESOURCE_LIB_DIR to something along the lines of ADDITIONAL_CLASSPATH_DIR - to make this YARN agnostic.

@shanthoosh shanthoosh merged commit de215f1 into apache:master Nov 5, 2019
@shanthoosh shanthoosh deleted the include_localized_resource_in_classpath branch November 5, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekshivanna abhishekshivanna abhishekshivanna approved these changes

@atoomula atoomula atoomula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shanthoosh @abhishekshivanna @atoomula