SAMZA-2477: JobModel isn't updated with latest "task.inputs" if enabled regex topic rewriter #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Zhang <shuai.xyz@gmail.com>
Signed-off-by: Alan Zhang <shuai.xyz@gmail.com>
mynameborat
approved these changes
Mar 16, 2020
samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Alan Zhang <shuai.xyz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom
JobModelManager provides readJobModel() function to let
JobCoordinator,ClusterBasedJboCoordinatorand etc know the latest JobModel information.If the users enable regex topic rewriter in their config,
readJobModel()function will dynamically load the latest Kafka topic list and generate new TaskModel with new topic partition mappings.However, it doesn't update the
task.inputsin JobModel's Config. So other services depend ontask.inputsinformation will still see stale data.Cause
JobModelManager.readJobModel()uses the original config instead of the updated config to buildJobModel.Changes
Use updated config to build final
JobModel.Tests
API Changes
None
Upgrade Instructions
None
Usage Instructions
None