SAMZA-2493: Keep checkpoint manager consumer open for repeated polling #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharathkk @xinyuiscool can you take a look over this? |
prateekm
reviewed
Mar 31, 2020
samza-core/src/main/java/org/apache/samza/config/TaskConfig.java
Outdated
Show resolved
Hide resolved
rmatharu-zz
reviewed
Apr 3, 2020
mynameborat
reviewed
Apr 3, 2020
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
Show resolved
Hide resolved
|
Do you plan to add tests? I noticed TBD in the description. |
@mynameborat yeah, added them |
mynameborat
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allow control of whether the underlying consumer backing a checkpoint manager will be left open (until stopped), or closed after the initial read of checkpoints
Changes: Introduces an internal config, injected by SamzaContainer, that is injected dependent on whether the container is standby or not, to control whether the container's checkpoint manager should have it's underlying consumer stopped after initial read or not.
Tests: Added a unit test each for the config set to true / false
API Changes: None
Upgrade Instructions: None
Usage Instructions: None