SAMZA-2617: Upgrade Kafka Client to 2.3.1 #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mynameborat @nickpan47 @xinyuiscool @sborya do you think you could take a long at some point please? |
|
I am oOO. @Sanil15 can you take point on this PR? |
Sanil15
approved these changes
Feb 23, 2021
|
Confirmed with boris, that we bump major version to 1.6 as soon as we cut 1.6 branch |
|
@Sanil15 Any ETA on the next Samza version release which would have the changes from this PR? We are really looking forward to the ZSTD compression support which kafka client v2.1.0 brings in. |
|
@Sanil15 @mynameborat - Any info would be really helpful here. |
tranjith
pushed a commit
to tranjith/samza
that referenced
this pull request
Mar 23, 2021
ehoner
pushed a commit
to ehoner/samza
that referenced
this pull request
Apr 11, 2023
SAMZA-2617: Upgrade Kafka Client to 2.3.1 (apache#1462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: The current Kafka version sits at 2.0.1 migrated up to 2.3.1. We get all the bug fixes, enhancements and security upgrades from the Kafka community.
2.4.1 is highest we can go to as it is the last supporting version of Scala 2.11. Done this partial upgrade as going higher TestZkLocalApplication runner becomes flaky and need to investigate why. Want the benefits of 2.3.1 to begin as first step.
Changes: Upgrade Kafka version to 2.3.1. Use TopicPartition as TopicAndPartition will be removed by Kafka 2.4.
Tests: Run the check-all tests.
API Changes: KafkaSystemConsumer protected method toTopicAndPartition removed as no longer required.
Upgrade Instructions: None
Usage Instructions: None