SAMZA-2620: Jackson upgrade 2.12.2 #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mynameborat @nickpan47 @xinyuiscool @sborya do you think you could take a long at some point please? |
|
I am out of office. @lakshmi-manasa-g can you take a look? |
kw2542
requested changes
Feb 23, 2021
...g/apache/samza/clustermanager/container/placement/ContainerPlacementMessageObjectMapper.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java
Outdated
Show resolved
Hide resolved
samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
Outdated
Show resolved
Hide resolved
perkss
force-pushed
the
SAMZA-2620-jackson-upgrade
branch
3 times, most recently
from
5e7813e
to
f4359b0
Compare
perkss
force-pushed
the
SAMZA-2620-jackson-upgrade
branch
from
f4359b0
to
45050d8
Compare
perkss
changed the title
|
@kw2542 the new version has been released, I have upgraded. So test back to how it was. Added in constraints on the Kafka module to manage the transitive Kafka dependencies of Jackson after that upgrade got merged. Please review when you get a moment. |
kw2542
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: The current version of Jackson is very old upgrade to latest version to get improvements, bug fixes and security enhancements.
In particular CVE-2019-10172
Changes: Upgrade Jackson dependency to 2.12.2.
Tests: Existing build tests
API Changes: None
Upgrade Instructions: None
Usage Instructions: None