SAMZA-1250: JobRunner.kill doesn't terminate cleanly with YarnJob. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmakes
commented
May 1, 2017
jmakes
commented
- The ClientHelper now checks inactive application IDs so it can get status for terminated jobs in addition to running jobs
- JobRunner.kill() waits for any finish, not just successful finish.
- A killed job is now considered successful.
added 4 commits
April 26, 2017 12:32
prateekm
approved these changes
May 1, 2017
|
|
||
| getAppsRsp | ||
| .asScala | ||
| .filter(appRep => ( !( |
There was a problem hiding this comment.
Minor: Maybe be cleaner to write this condition as a multi-line block using {} with an extracted val for appStatus.
Also, not clear what Rsp and Rep are. Maybe use a more verbose name?
| @@ -249,8 +249,23 @@ class ClientHelper(conf: Configuration) extends Logging { | |||
| .toList | |||
| } | |||
|
|
|||
| def getPreviousApplicationIds(appName: String): List[ApplicationId] = { | |||
| val getAppsRsp = yarnClient.getApplications | |||
There was a problem hiding this comment.
Minor: val apps or whatever that type is?
| @@ -279,7 +294,7 @@ class ClientHelper(conf: Configuration) extends Logging { | |||
|
|
|||
| private def convertState(state: YarnApplicationState, status: FinalApplicationStatus): Option[ApplicationStatus] = { | |||
| applicationIds.sorted.reverse.headOption | ||
| } else { | ||
| // Couldn't find an active applicationID. Use one the latest finished ID. | ||
| val pastApplicationIds = client.getPreviousApplicationIds(applicationName) |
There was a problem hiding this comment.
Minor: Do we want to log this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.