SAMZA-1271: Guarantee predictable, deterministic order for operator initialization and finalization #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @prateekm , @nickpan47 , @xinyuiscool for reviews! |
prateekm
approved these changes
Jun 2, 2017
| @@ -18,6 +18,7 @@ | |||
| */ | |||
| package org.apache.samza.operators.impl; | |||
|
|
|||
| import com.google.common.collect.Lists; | |||
There was a problem hiding this comment.
Minor: Maybe Collections.reverse?
There was a problem hiding this comment.
Lists.reverse is slightly nicer as it does not mutate the passed in list. We appear to be having a guava dependency anyways in samza-core
| public void close() { | ||
| filterFn.close(); | ||
| } | ||
|
|
| @@ -71,6 +71,11 @@ private OperatorSpecs() {} | |||
| public void init(Config config, TaskContext context) { | |||
| mapFn.init(config, context); | |||
| } | |||
|
|
|||
| @Override | |||
| public void close() { | |||
| @@ -26,6 +26,10 @@ | |||
| * | |||
| * <p> Implement {@link #close()} to free resources used during the execution of the function, clean up state etc. | |||
| * | |||
| * <p> Order of finalization: {@link ClosableFunction}s are invoked in the reverse topological order of operators in the | |||
There was a problem hiding this comment.
"Order of closing", "are closed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the order of initialization of operators in the Samza high level API is not deterministic. The non-determinism arises from two primary causes:
OperatorSpecs for a givenMessageStreamOperatorImpls in theOperatorImplGraphWe aim to provide the following 2 guarantees in this patch:
For any 2 operators A, B in the graph, if B consumes the output of A: