SAMZA-1381: Create Utility Class for interacting with Azure Table Storage #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawasChhokra
force-pushed
the
TableUtils
branch
2 times, most recently
from
15dd932
to
bfc9740
Compare
navina
approved these changes
Aug 7, 2017
| * @return Iterable list of processor entities. | ||
| */ | ||
| public Iterable<ProcessorEntity> getEntitiesWithPartition(String partitionKey) { | ||
| String partitionFilter = TableQuery.generateFilterCondition(this.PARTITION_KEY, TableQuery.QueryComparisons.EQUAL, partitionKey); |
There was a problem hiding this comment.
nit: s/this.PARTITION_KEY/PARTITION_KEY/
| public Iterable<ProcessorEntity> getEntitiesWithPartition(String partitionKey) { | ||
| String partitionFilter = TableQuery.generateFilterCondition(this.PARTITION_KEY, TableQuery.QueryComparisons.EQUAL, partitionKey); | ||
| TableQuery<ProcessorEntity> partitionQuery = TableQuery.from(ProcessorEntity.class).where(partitionFilter); | ||
| return table.execute(partitionQuery); |
There was a problem hiding this comment.
Any exception handling required here?
There was a problem hiding this comment.
None of the internal methods used throw an exception. Hence, not required.
PawasChhokra
force-pushed
the
TableUtils
branch
from
bfc9740
to
8bde091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1: AzureClient + AzureConfig
PR 2: LeaseBlobManager
PR 3: BlobUtils + JobModelBundle
PR 4: TableUtils + ProcessorEntity (Current PR)