SAMZA-1821: fix the IllegalStateException complaining duplicate key when fetching systemStream configs #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen fetching systemStream configs
bharathkk
suggested changes
Aug 24, 2018
| @@ -113,13 +113,13 @@ public SamzaSqlApplicationConfig(Config staticConfig) { | |||
| inputSystemStreamConfigBySource = queryInfo.stream() | |||
| .map(QueryInfo::getSources) | |||
| .flatMap(Collection::stream) | |||
| .collect(Collectors.toMap(Function.identity(), src -> ioResolver.fetchSourceInfo(src))); | |||
| .collect(Collectors.toMap(Function.identity(), ioResolver::fetchSourceInfo, (src1, src2) -> src1)); | |||
There was a problem hiding this comment.
How about we use distinct() before collect() to save some resolver calls to fetch source information?
There was a problem hiding this comment.
right. thanks for pointing this out.
|
|
||
| Set<SqlIOConfig> systemStreamConfigs = new HashSet<>(inputSystemStreamConfigBySource.values()); | ||
|
|
||
| outputSystemStreamConfigsBySource = queryInfo.stream() | ||
| .map(QueryInfo::getSink) | ||
| .collect(Collectors.toMap(Function.identity(), x -> ioResolver.fetchSinkInfo(x))); | ||
| .collect(Collectors.toMap(Function.identity(), ioResolver::fetchSinkInfo, (src1, src2) -> src1)); |
| @@ -24,7 +24,6 @@ | |||
| import java.io.PrintWriter; | |||
| import java.util.List; | |||
|
|
|||
| import org.apache.samza.sql.testutil.SqlFileParser; | |||
There was a problem hiding this comment.
Just cleaning up code when I see it.
atoomula
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to fix IllegalStateException complaining duplicate key when fetching resource configs in SamzaSqlApplicationConfig.
How was this patch tested?
Pass the local build and current unit tests.
Added a new unit test.