SAMZA-1970: Support for physical names in InMemorySystem #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich results in StackOverflows
|
@vjagadish1989 please merge when you have time |
shanthoosh
reviewed
Oct 31, 2018
| @@ -45,7 +45,7 @@ | |||
| } | |||
|
|
|||
| public InMemoryOutputDescriptor withPhysicalName(String physicalName) { | |||
| withPhysicalName(physicalName); | |||
| super.withPhysicalName(physicalName); | |||
There was a problem hiding this comment.
Please correct me If i'm wrong here. Before this change, was this method going into a indefinite recursive call eventually running out of stack?
There was a problem hiding this comment.
yes if this is used, I mentioned this in a comment above
asfgit
pushed a commit
that referenced
this pull request
Oct 31, 2018
if super is not there, java compiles this to this.withPhysicalName which results in StackOverflows Author: Sanil15 <sanil.jain15@gmail.com> Reviewers: Jagadish<jagadish@apache.org> Closes #788 from Sanil15/SAMZA-1970-edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if super is not there, java compiles this to this.withPhysicalName which results in StackOverflows