SAMZA-2094: Implement the StartpointVisitor for KafkaSystemConsumer. #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cameronlee314 @dnishimura |
|
Please take a look at the comment #869 (comment) regarding not having KafkaSystemConsumer directly implement StartpointVisitor. |
|
@cameronlee314 Thanks for the review. Addressed the comment. |
| @@ -330,6 +341,57 @@ public String getSystemName() { | |||
| return systemName; | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| static class KafkaStartpointVisitor implements StartpointVisitor { | |||
There was a problem hiding this comment.
Could you please change the name to indicate it is responsible for startpoint registration? "StartpointVisitor" can be anything that needs to act on a Startpoint, so just using KafkaStartpointVisitor isn't specific enough.
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Outdated
Show resolved
Hide resolved
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemConsumer.java
Outdated
Show resolved
Hide resolved
shanthoosh
commented
Feb 4, 2019
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Outdated
Show resolved
Hide resolved
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemConsumer.java
Show resolved
Hide resolved
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemConsumer.java
Outdated
Show resolved
Hide resolved
shanthoosh
force-pushed
the
SAMZA-2094
branch
from
388db33
to
d702d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.